Comments on: Unnecessary Complexity Case Study #1: Untyped Enum Comparisons http://landofjosh.com/2009/05/unnecessary-complexity-case-study-1-untyped-enum-comparisons/ software development under the big arch Sat, 30 Jan 2010 20:20:08 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Pauletta http://landofjosh.com/2009/05/unnecessary-complexity-case-study-1-untyped-enum-comparisons/comment-page-1/#comment-38 Pauletta Sat, 04 Jul 2009 03:13:06 +0000 http://landofjosh.com/?p=12#comment-38 i thought you said you added some posts?? I am so sad to see only old stuff i thought you said you added some posts?? I am so sad to see only old stuff

]]> By: Brian Rodewald http://landofjosh.com/2009/05/unnecessary-complexity-case-study-1-untyped-enum-comparisons/comment-page-1/#comment-9 Brian Rodewald Tue, 19 May 2009 03:44:10 +0000 http://landofjosh.com/?p=12#comment-9 Yeah, I hate the enum.ToString() comparisons as well, but not nearly as much as I hate the string.ToLower() comparisons (mostly for exactly the reasons you mention). My suggestion for your next Agent Ralph expansion: an automation to transform (stringName.ToLower() == "xxx") into (stringName.Equals("xxx", StringComparison.OrdinalIgnoreCase)), which of course won't work in culture-sensitive scenarios but still beats the hell out of ToLower(), both for defensive coding and performance. Yeah, I hate the enum.ToString() comparisons as well, but not nearly as much as I hate the string.ToLower() comparisons (mostly for exactly the reasons you mention). My suggestion for your next Agent Ralph expansion: an automation to transform

(stringName.ToLower() == “xxx”)

into

(stringName.Equals(“xxx”, StringComparison.OrdinalIgnoreCase)),

which of course won’t work in culture-sensitive scenarios but still beats the hell out of ToLower(), both for defensive coding and performance.

]]>